Remove explicit dependency on SciMLBase
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-graham
reviewed
Mar 12, 2024
giordano
changed the title
SciMLBase
matt-graham
approved these changes
Mar 12, 2024
|
With regards to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## mmg/bump-to-v1.1.0 #256 +/- ##
======================================================
- Coverage 94.05% 92.48% -1.57%
======================================================
Files 7 7
Lines 353 386 +33
======================================================
+ Hits 332 357 +25
- Misses 21 29 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the reason why we're getting failures in the test with Julia v1.10 in #254 is because the combination of packages
[email protected]+[email protected]is allowed by the registry but in practice incompatible. While I believe this should be fixed in the registry by not to allow getting incompatible versions, we should be able to work around the issue by just not requiringSciMLBaseexplicitly and allow the registry to pull more up-to-date versions, with fewer constraints.Haven't tested locally, but I'm moderately confident this should do the trick.